Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible Playbook Control UI #399

Merged
merged 9 commits into from Feb 17, 2017
Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Feb 15, 2017

Ansible Playbook Control UI

Screeenshots with updated labels : #424

@lgalis
Copy link
Contributor Author

lgalis commented Feb 15, 2017

@miq-bot add_label wip, enhancement

@miq-bot miq-bot added the wip label Feb 15, 2017
@lgalis lgalis force-pushed the playbook_action_ui branch 4 times, most recently from 0c725ec to c2f9ac5 Compare February 16, 2017 13:59
@lgalis lgalis changed the title [WIP] Ansible Playbook Control UI Ansible Playbook Control UI Feb 16, 2017
@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2017

@lgalis unrecognized command '-', ignoring...

Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone

@lgalis
Copy link
Contributor Author

lgalis commented Feb 16, 2017

@mkanoor, @dclarizio - please review

@lgalis
Copy link
Contributor Author

lgalis commented Feb 16, 2017

@miq-bot remove_label wip

@lgalis
Copy link
Contributor Author

lgalis commented Feb 17, 2017

@himdel, @dclarizio - separated the part that was required for core in a separate PR that was merged - ManageIQ/manageiq#13943. Update the dependencies for this PR so it can be merged. Removing the core dependency label

@miq-bot
Copy link
Member

miq-bot commented Feb 17, 2017

@lgalis Cannot remove the following label because they are not recognized: pending_core

@lgalis
Copy link
Contributor Author

lgalis commented Feb 17, 2017

@miq-bot remove_label pending core

@mkanoor
Copy link
Contributor

mkanoor commented Feb 17, 2017

@lgalis
When a new action is being created the host values are not being saved if you go with the default host selection on the screen.

Steps: Start a new Action, Select a name, Select a Template, leave default settings for host and click on Add

screen shot 2017-02-17 at 10 47 19 am

#<MiqAction id: 39, name: "66a1f452-f528-11e6-8fee-b8e85631ca6a", description: "Demo1", created_on: "2017-02-17 15:47:35", updated_on: "2017-02-17 15:47:35", guid: "66a1f452-f528-11e6-8fee-b8e85631ca6a", action_type: "run_ansible_playbook", options: {:service_template_id=>"1", :use_event_target=>false, :use_localhost=>false}>

use_localhost the default setting is false even though the UI shows it as being selected.

@mkanoor
Copy link
Contributor

mkanoor commented Feb 17, 2017

👍

@miq-bot
Copy link
Member

miq-bot commented Feb 17, 2017

Checked commits lgalis/manageiq-ui-classic@86a702b~...1a9feda with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 1 offense detected

app/controllers/miq_policy_controller/miq_actions.rb

  • ❕ - Line 151, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for update_playbook_variables is too high. [24.29/20]

@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 17, 2017
@h-kataria h-kataria merged commit e02d0fc into ManageIQ:master Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants