Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on default filters page #4127

Merged
merged 1 commit into from Jun 14, 2018

Conversation

mzazrivec
Copy link
Contributor

With #4116 in place, navigate to: My Settings → Default Filters, you'll witness the following error:

F, [2018-06-12T16:20:12.505321 #10918] FATAL -- : Error caught: [ArgumentError] comparison of Array with Array failed
manageiq-ui-classic/app/presenters/tree_builder_default_filters.rb:21:in `sort_by'
manageiq-ui-classic/app/presenters/tree_builder_default_filters.rb:21:in `prepare_data'
manageiq-ui-classic/app/presenters/tree_builder_default_filters.rb:30:in `initialize'
manageiq-ui-classic/app/controllers/configuration_controller.rb:511:in `new'
manageiq-ui-classic/app/controllers/configuration_controller.rb:511:in `set_form_vars'
manageiq-ui-classic/app/controllers/configuration_controller.rb:64:in `edit'
manageiq-ui-classic/app/controllers/configuration_controller.rb:72:in `change_tab'

@miq-bot
Copy link
Member

miq-bot commented Jun 12, 2018

Checked commit mzazrivec@23acdce with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec changed the title Fix error on default filter page Fix error on default filters page Jun 13, 2018
@ZitaNemeckova
Copy link
Contributor

Tested in UI:
screen shot 2018-06-14 at 11 00 23 am
LGTM 👍

@himdel himdel self-assigned this Jun 14, 2018
@himdel himdel added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 14, 2018
@himdel himdel merged commit 42fc71c into ManageIQ:master Jun 14, 2018
@mzazrivec mzazrivec deleted the fix_error_on_default_filters_page branch June 14, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants