Show Configuration Workflows in UI #4138

h-kataria · 2018-06-13T20:54:29Z

Changes to show list of Job Templates and Configuration Workflows in existing UI under Automation/Ansible Tower/Explorer in Templates Accordion.

https://bugzilla.redhat.com/show_bug.cgi?id=1590441

before:

after:

Depends on ManageIQ/manageiq#17720

martinpovolny · 2018-06-21T12:20:11Z

Looks good. Restarting travis.

h-kataria · 2018-06-21T15:43:07Z

@martinpovolny test failures are due to backend PR not being merged yet.

h-kataria · 2018-06-22T17:00:42Z

@dclarizio @gmcculloug @tinaafitz mostly addressed all the items discussed that were needed in this PR, now we need to change all references to ConfigurationScriptBase class once model changes are made, related to sub-classing of Workflow Templates.
As discussed, In a follow up PR will add changes to show child Jobs off of Ansible Service Summary screen, once we have back-end work done to be able to create a Service with Workflow Template.

cc @lgalis

miq-bot · 2018-06-26T11:34:08Z

This pull request is not mergeable. Please rebase and repush.

h-kataria · 2018-07-10T18:55:35Z

@martinpovolny please re-review, this is still waiting on core PR merge

martinpovolny · 2018-07-14T13:23:19Z

@h-kataria : the style issues in app/controllers/catalog_controller.rb seem to be easy to fix.
The is_template_record? complaint is also simple to fix.

Other than that I have no further comments. Thx!

martinpovolny · 2018-07-25T12:32:30Z

Oh, the core PR is still not merged :-(

Changes to show list of Job Templates and Configuration Workflows in existing UI under Automation/Ansible Tower/Explorer in Templates Accordion. https://bugzilla.redhat.com/show_bug.cgi?id=1590441

- Further changes to update titles on screen and show toolbar buttons when Workflow Template record is selected, and render correct textual summary when printing summary to PDF. - Changes to Catalo Items editor to show grouping in the Template drop down. https://bugzilla.redhat.com/show_bug.cgi?id=1590441

Reverted some of the changes that were made to use ManageIQ/manageiq#17580 and adjusted code to use subclass in ManageIQ/manageiq#17659 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590441 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468339

Reverted some of the changes that were made to use ManageIQ/manageiq#17580 and adjusted code to use subclass in ManageIQ/manageiq#17720 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590441 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468339

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590441 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468339

miq-bot · 2018-07-31T20:28:24Z

Checked commits h-kataria/manageiq-ui-classic@96b8283~...26ae0c9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
18 files checked, 1 offense detected

**

💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

h-kataria · 2018-07-31T21:10:23Z

@martinpovolny core PR is merged, addressed all rubocop warnings as well. Ready for merge.

bzwei · 2018-08-02T20:17:10Z

app/controllers/catalog_controller.rb

+  def available_job_templates(manager_id)
+    @edit[:new][:available_templates] = []
+    all_job_templates = ExtManagementSystem.find_by(:id => manager_id).send('configuration_scripts').collect { |t| [t.name, t.id] }.sort
+    all_workflow_templates = ExtManagementSystem.find_by(:id => manager_id).send('configuration_workflows').collect { |t| [t.name, t.id] }.sort


@h-kataria method configuration_workflows does not exist. You need to rework on this PR.

@jameswnl please let me know what is the new method name that i should use. @bzwei i did test my PR as is yesterday and i was able to see correct values in the drop down.

you can just filter what you've got from the previous query all_job_templates to get the workflows.

(If you are making another call to db to get just the workflows, that would defeat the purpose of the whole remodeling in configuration_workflow which is to allow ui to get back both types of objects in one db/api call)

Follow up fix for changes requested in ManageIQ#4138 (review)

Addressed codeclimate warning Method available_job_templates has a Cognitive Complexity of 6 Follow up fix for changes requested in ManageIQ#4138 (review)

Addressed codeclimate warning Method available_job_templates has a Cognitive Complexity of 6 Follow up fix for changes requested in ManageIQ#4138 (review) https://bugzilla.redhat.com/show_bug.cgi?id=1590441

h-kataria added enhancement pending core automation/ansible tower gaprindashvili/no labels Jun 13, 2018

h-kataria requested a review from martinpovolny as a code owner June 13, 2018 20:54

h-kataria mentioned this pull request Jun 13, 2018

Changes to support UI changes to show Configuration Workflows in UI ManageIQ/manageiq#17580

Closed

h-kataria force-pushed the configuration_workflows_ui branch from 50bca7a to 12cee3c Compare June 18, 2018 21:39

martinpovolny self-assigned this Jun 21, 2018

h-kataria force-pushed the configuration_workflows_ui branch from 12cee3c to d16e470 Compare June 21, 2018 14:03

h-kataria changed the title ~~Show Configuration Workflows in UI~~ [WIP] - Show Configuration Workflows in UI Jun 22, 2018

h-kataria added the wip label Jun 22, 2018

miq-bot added the unmergeable label Jun 26, 2018

lgalis force-pushed the configuration_workflows_ui branch 2 times, most recently from 26a29e5 to 73aaeed Compare June 26, 2018 19:40

miq-bot removed the unmergeable label Jun 27, 2018

h-kataria force-pushed the configuration_workflows_ui branch 5 times, most recently from d8a6e6e to b8a92e1 Compare July 9, 2018 15:07

h-kataria changed the title ~~[WIP] - Show Configuration Workflows in UI~~ Show Configuration Workflows in UI Jul 10, 2018

h-kataria removed the wip label Jul 10, 2018

d-m-u approved these changes Jul 24, 2018

View reviewed changes

h-kataria and others added 3 commits July 31, 2018 14:32

Show Configuration Workflows in UI

96b8283

Changes to show list of Job Templates and Configuration Workflows in existing UI under Automation/Ansible Tower/Explorer in Templates Accordion. https://bugzilla.redhat.com/show_bug.cgi?id=1590441

h-kataria force-pushed the configuration_workflows_ui branch from 528e87d to f8c41a4 Compare July 31, 2018 19:34

h-kataria force-pushed the configuration_workflows_ui branch from f8c41a4 to 661b789 Compare July 31, 2018 19:36

h-kataria removed the pending core label Jul 31, 2018

addressed rubocop warnings.

26ae0c9

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590441 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468339

h-kataria force-pushed the configuration_workflows_ui branch from 00cdb56 to 26ae0c9 Compare July 31, 2018 20:25

martinpovolny merged commit 0a0df98 into ManageIQ:master Aug 2, 2018

martinpovolny added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 2, 2018

bzwei reviewed Aug 2, 2018

View reviewed changes

h-kataria added a commit to h-kataria/manageiq-ui-classic that referenced this pull request Aug 3, 2018

Fixed Templates drop down in catalog item editor

1b6d115

Follow up fix for changes requested in ManageIQ#4138 (review)

h-kataria mentioned this pull request Aug 3, 2018

Fixed Templates drop down in catalog item editor #4413

Merged

h-kataria added a commit to h-kataria/manageiq-ui-classic that referenced this pull request Aug 3, 2018

Fixed Templates drop down in catalog item editor

15845b1

Follow up fix for changes requested in ManageIQ#4138 (review)

h-kataria added a commit to h-kataria/manageiq-ui-classic that referenced this pull request Aug 3, 2018

Fixed Templates drop down in catalog item editor

1d49f19

Follow up fix for changes requested in ManageIQ#4138 (review)

h-kataria deleted the configuration_workflows_ui branch October 24, 2018 22:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show Configuration Workflows in UI #4138

Show Configuration Workflows in UI #4138

h-kataria commented Jun 13, 2018 •

edited

martinpovolny commented Jun 21, 2018

h-kataria commented Jun 21, 2018

h-kataria commented Jun 22, 2018

miq-bot commented Jun 26, 2018

h-kataria commented Jul 10, 2018

martinpovolny commented Jul 14, 2018 •

edited

martinpovolny commented Jul 25, 2018

miq-bot commented Jul 31, 2018

h-kataria commented Jul 31, 2018

bzwei Aug 2, 2018

h-kataria Aug 2, 2018

jameswnl Aug 2, 2018

Show Configuration Workflows in UI #4138

Show Configuration Workflows in UI #4138

Conversation

h-kataria commented Jun 13, 2018 • edited

martinpovolny commented Jun 21, 2018

h-kataria commented Jun 21, 2018

h-kataria commented Jun 22, 2018

miq-bot commented Jun 26, 2018

h-kataria commented Jul 10, 2018

martinpovolny commented Jul 14, 2018 • edited

martinpovolny commented Jul 25, 2018

miq-bot commented Jul 31, 2018

h-kataria commented Jul 31, 2018

bzwei Aug 2, 2018

Choose a reason for hiding this comment

h-kataria Aug 2, 2018

Choose a reason for hiding this comment

jameswnl Aug 2, 2018

Choose a reason for hiding this comment

h-kataria commented Jun 13, 2018 •

edited

martinpovolny commented Jul 14, 2018 •

edited