Ensure new dialog user component is used for service reconfiguration #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label gaprindashvili/yes, bug, blocker @d-m-u Can you review please? |
|
Checked commit eclarizio@108d88d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jun 14, 2018
Ensure new dialog user component is used for service reconfiguration (cherry picked from commit e3c4096) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591484
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reconfiguring a service, the UI was attempting to use the old dialog-user component, and therefore wasn't displaying properly. This change ensures the reconfiguration dialog goes through the new dialog-user component and submits to the correct 'reconfigure' API endpoint.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1580987