Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support to filter events by new group levels #4217

Merged
merged 1 commit into from Jul 30, 2018
Merged

adding support to filter events by new group levels #4217

merged 1 commit into from Jul 30, 2018

Conversation

CharlleDaniel
Copy link
Member

@CharlleDaniel CharlleDaniel commented Jun 26, 2018 •
edited

This PR is able to:

  • Refactor the timeline page to support filter events using the group_levels
  • Color the event accordingly the severity
    timeline2
  • Color the Group Level information accordingly the severity
    image

Depends_on: PR 17611 - MERGED
Depends_on: PR 17702 - MERGED

@CharlleDaniel CharlleDaniel changed the title Refactor to Add support filter events by new group levels Refactor to add support filter events by new group levels Jun 26, 2018
@CharlleDaniel CharlleDaniel changed the title Refactor to add support filter events by new group levels [WIP] Refactor to add support filter events by new group levels Jun 26, 2018
@miq-bot miq-bot added the wip label Jun 26, 2018
@h-kataria h-kataria self-assigned this Jul 10, 2018
@CharlleDaniel CharlleDaniel mentioned this pull request Jul 13, 2018
Merged
@CharlleDaniel CharlleDaniel changed the title [WIP] Refactor to add support filter events by new group levels Refactor to add support filter events by new group levels Jul 20, 2018
@miq-bot miq-bot removed the wip label Jul 20, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 20, 2018

Checked commit https://github.com/CharlleDaniel/manageiq-ui-classic/commit/49b85a2bed65dfaedf25e850293b8be683c38ed5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. 👍

@CharlleDaniel
Copy link
Member Author

@h-kataria Could you review this PR as well?

@CharlleDaniel CharlleDaniel reopened this Jul 23, 2018
@CharlleDaniel CharlleDaniel reopened this Jul 23, 2018
@CharlleDaniel CharlleDaniel changed the title Refactor to add support filter events by new group levels adding support to filter events by new group levels Jul 23, 2018
@h-kataria h-kataria added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 30, 2018
@h-kataria h-kataria merged commit bd5be09 into ManageIQ:master Jul 30, 2018
@h-kataria h-kataria mentioned this pull request Nov 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
enhancement timelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CharlleDaniel @miq-bot @h-kataria