Adding Physical Chassis Location LED actions #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasgabriel
force-pushed
the
ph_chassis_actions
branch
from
7c6af15
to
71c412c
Compare
|
This pull request is not mergeable. Please rebase and repush. |
douglasgabriel
force-pushed
the
ph_chassis_actions
branch
from
71c412c
to
a18d1dc
Compare
|
|
||
| def self.display_methods | ||
| %w(physical_chassis) | ||
| end |
There was a problem hiding this comment.
you might need menu_section :physical_chassis line here
| @@ -0,0 +1,113 @@ | |||
| module PhysicalChassisHelper::TextualSummary | |||
There was a problem hiding this comment.
Please, add tests for this helper. There should be enough example both simple and complex, many from your team. Thx!
| - case @showtype | ||
| - when "main" | ||
| = render :partial => 'layouts/textual_groups_generic' | ||
| - when "timeline" |
There was a problem hiding this comment.
Are you adding timeline? if not, you don't need this.
|
Hallo. Still waiting for the API PR, but I at least added some comments in-line so that you can move this PR forward. |
douglasgabriel
force-pushed
the
ph_chassis_actions
branch
from
a18d1dc
to
f731359
Compare
|
Checked commit douglasgabriel@f731359 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
martinpovolny
added
enhancement
compute/physical infrastructure
gaprindashvili/no
and removed
pending core
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is able to
Depends on
ManageIQ/manageiq#17668- Merged#4065- MergedManageIQ/manageiq-api#410- Merged