Make sure that react helper always closes the div tag #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
react-content-tag
branch
from
36a722d
to
a2cf194
Compare
skateman
changed the title
|
Checked commit skateman@a2cf194 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Hyperkid123
approved these changes
Jul 19, 2018
hstastna
approved these changes
Jul 19, 2018
|
@miq-bot assign @mzazrivec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tagmethod sometimes behaves weird (maybe a rails bug) and doesn't close the tags. This can break the whole DOM and e.g. hide the left side tree when creating a tenant.@miq-bot add_reviewer @hstastna
@miq-bot add_reviewer @Hyperkid123
Closes #4273
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1593152