Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Driving Event field for Containers. #4324

Merged
merged 1 commit into from Jul 20, 2018
Merged

Hide Driving Event field for Containers. #4324

merged 1 commit into from Jul 20, 2018

Conversation

h-kataria
Copy link
Contributor

As per https://bugzilla.redhat.com/show_bug.cgi?id=1578115#c26 in BZ removed an option to be able to set/display 'Driving Event' field when adding/editing an Alert that's based on 'Container Node' or 'Container Project' models.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578115

before:
before

after:
container_alert_after

non_container_aert

@h-kataria h-kataria force-pushed the alert_editor_changes_for_contaiers branch from f67be24 to 67d21a0 Compare July 19, 2018 17:49
@h-kataria h-kataria removed the wip label Jul 19, 2018
@h-kataria h-kataria changed the title [WIP] Hide Driving Event field for Containers. Hide Driving Event field for Containers. Jul 19, 2018
@h-kataria h-kataria requested a review from lgalis July 19, 2018 17:49
@h-kataria
Copy link
Contributor Author

@lgalis please review/test

lgalis
lgalis approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@lgalis lgalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Verified that the Driving Event is not displayed for Containers but displayed for the other alret types.

@h-kataria h-kataria force-pushed the alert_editor_changes_for_contaiers branch from 67d21a0 to 1879d29 Compare July 19, 2018 22:03
@mzazrivec
Copy link
Contributor

@h-kataria Could you please address the rubocop warnings in the spec? Thanks.

@h-kataria h-kataria force-pushed the alert_editor_changes_for_contaiers branch from 1879d29 to c4dd02b Compare July 20, 2018 14:29
@h-kataria
Hide Driving Event field for Containers.
6b57930 
As per https://bugzilla.redhat.com/show_bug.cgi?id=1578115#c26 in BZ removed an option to be able to set/display 'Driving Event' field when adding/editing an Alert that's based on 'Container Node' or 'Container Project' models.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578115
@h-kataria h-kataria force-pushed the alert_editor_changes_for_contaiers branch from c4dd02b to 6b57930 Compare July 20, 2018 14:37
@miq-bot
Copy link
Member

miq-bot commented Jul 20, 2018

Checked commit h-kataria@6b57930 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec mzazrivec assigned mzazrivec and unassigned dclarizio Jul 20, 2018
@mzazrivec mzazrivec added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 20, 2018
@mzazrivec mzazrivec merged commit 6b0c400 into ManageIQ:master Jul 20, 2018
@h-kataria h-kataria deleted the alert_editor_changes_for_contaiers branch July 23, 2018 16:07
simaishi pushed a commit that referenced this pull request Sep 17, 2018
@mzazrivec @simaishi
Merge pull request #4324 from h-kataria/alert_editor_changes_for_cont…
910a335 
…aiers

Hide Driving Event field for Containers.
(cherry picked from commit 6b0c400)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1607438
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 910a335d0d1bf17a12dad529a5f01d487cc3f5e8
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Jul 20 17:24:35 2018 +0200

    Merge pull request #4324 from h-kataria/alert_editor_changes_for_contaiers
    
    Hide Driving Event field for Containers.
    (cherry picked from commit 6b0c4001d649c6be2f16ed49e13bb4e04e187f83)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1607438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgalis lgalis lgalis approved these changes

Assignees

@mzazrivec mzazrivec

Labels
blocker bug control gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@h-kataria @mzazrivec @miq-bot @simaishi @lgalis @dclarizio