Display "FloatingIp belongs to NetworkRouter" relation #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we enhance UI with relation between NetworkRouter and FloatingIp (and vice versa). Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
miha-plesko
force-pushed
the
router-floatingip-relation
branch
from
355921a
to
8c545fa
Compare
|
@himdel FYI added the missing condition in show.html.haml so that it now renders NetworkRouter's own FloatingIps as expected. Thanks for helping me out! |
|
Checked commit miha-plesko@8c545fa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we enhance UI with relation between NetworkRouter and FloatingIp (and vice versa):
RFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574922
@miq-bot add_label enhancement
@miq-bot assign @himdel