Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ruby-scrutinizer-run to prevent time out of Scrutinizer #4340

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Disable ruby-scrutinizer-run to prevent time out of Scrutinizer #4340

merged 1 commit into from
Jul 26, 2018

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Jul 24, 2018 •
edited
Loading

ruby-scrutinizer-run runs too long for some reason and Scrutinizer times out after a while.

screen shot 2018-07-26 at 10 35 07 am

So skipping ruby-scrutinizer-run for now.

@miq-bot add_label wip

@miq-bot miq-bot changed the title Try to fix Scrutinizer [WIP] Try to fix Scrutinizer Jul 24, 2018
@miq-bot miq-bot added the wip label Jul 24, 2018
@ZitaNemeckova
Try to fix Scrutinizer
0b1d005 
and probably fail
@miq-bot
Copy link
Member

miq-bot commented Jul 25, 2018

Checked commit ZitaNemeckova@0b1d005 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

.scrutinizer.yml

  • ⚠️ - Line 14, Col 11 - indentation - wrong indentation: expected 8 but found 10

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Try to fix Scrutinizer Try to fix Scrutinizer Jul 26, 2018
@miq-bot miq-bot removed the wip label Jul 26, 2018
@ZitaNemeckova ZitaNemeckova changed the title Try to fix Scrutinizer [WIP] Disable ruby-scrutinizer-run to prevent time out of Scrutinizer Jul 26, 2018
@miq-bot miq-bot added the wip label Jul 26, 2018
@ZitaNemeckova
Copy link
Contributor Author

ZitaNemeckova commented Jul 26, 2018 •
edited
Loading

@miq-bot add_label gaprindashvili/no, developer

@ZitaNemeckova
Copy link
Contributor Author

cc @himdel @martinpovolny @skateman

skateman
skateman approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Disable ruby-scrutinizer-run to prevent time out of Scrutinizer Disable ruby-scrutinizer-run to prevent time out of Scrutinizer Jul 26, 2018
@miq-bot miq-bot removed the wip label Jul 26, 2018
@himdel
Copy link
Contributor

himdel commented Jul 26, 2018

The idea here is:

this disables ruby-scrutinizer-run by overriding the relevant part of the repository config, with the exact same thing except for ruby-scrutinizer-run

@ZitaNemeckova
Copy link
Contributor Author

And it's not working 🗡

@miq-bot add_label wip

@miq-bot miq-bot changed the title Disable ruby-scrutinizer-run to prevent time out of Scrutinizer [WIP] Disable ruby-scrutinizer-run to prevent time out of Scrutinizer Jul 26, 2018
@miq-bot miq-bot added the wip label Jul 26, 2018
@ZitaNemeckova
Copy link
Contributor Author

ZitaNemeckova commented Jul 26, 2018 •
edited
Loading

It's working but node tests is failing but it's broken on master as well so ignoring :D
@miq-bot remove_label wip

EDIT: Fixing it in #4358

@miq-bot miq-bot changed the title [WIP] Disable ruby-scrutinizer-run to prevent time out of Scrutinizer Disable ruby-scrutinizer-run to prevent time out of Scrutinizer Jul 26, 2018
@miq-bot miq-bot removed the wip label Jul 26, 2018
@himdel himdel merged commit 04326c8 into ManageIQ:master Jul 26, 2018
@himdel himdel self-assigned this Jul 26, 2018
@himdel himdel added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@himdel himdel

Labels
developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZitaNemeckova @miq-bot @himdel @skateman