Dialog sample screen: apply selectpicker class to dropdown select #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @martinpovolny |
skateman
reviewed
Aug 3, 2018
| @@ -64,7 +64,7 @@ | |||
| %label{:for => "dialog_field_radio_sample_2"} Option 2 | |||
|
|
|||
| - if field.type == "DialogFieldDropDownList" | |||
| = select_tag("#{field.id}", options_for_select([_("Option 1"), _("Option 2")])) | |||
| = select_tag("#{field.id}", options_for_select([_("Option 1"), _("Option 2")]), {:class => 'selectpicker'}) | |||
There was a problem hiding this comment.
One minor thing, you don't need the curly braces around the last hash argument.
mzazrivec
force-pushed
the
apply_selectpicker_class_to_dropdown_in_dialog_sample_screen
branch
from
3980226
to
147bafb
Compare
|
Checked commit mzazrivec@147bafb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
deleted the
apply_selectpicker_class_to_dropdown_in_dialog_sample_screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
