Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't render table header for empty automate domain and namespace #4401

Merged
merged 1 commit into from Aug 7, 2018
Merged

Don't render table header for empty automate domain and namespace #4401

merged 1 commit into from Aug 7, 2018

Conversation

mzazrivec
Copy link
Contributor

Before:
domain-before
namespace-before

After:
domain01-after
namespace-after

@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2018

Checked commit mzazrivec@e3a6804 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

skateman
skateman approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@skateman
Copy link
Member

skateman commented Aug 3, 2018

@miq-bot assign @martinpovolny

@martinpovolny martinpovolny added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 7, 2018
@martinpovolny martinpovolny merged commit 68ee3a0 into ManageIQ:master Aug 7, 2018
@mzazrivec mzazrivec deleted the dont_render_table_for_empty_domain_and_namespace branch August 7, 2018 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@martinpovolny martinpovolny

Labels
automation/automate bug formatting/styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzazrivec @miq-bot @skateman @martinpovolny