There is no need to check for tab title uniqueness for default dashboard #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
dashboard_title_change_fix
branch
3 times, most recently
from
2dbbff9
to
cbbaa23
Compare
Fixed condition, Only need a check for tab title uniqueness within a group for selected dashboard Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1614872
h-kataria
force-pushed
the
dashboard_title_change_fix
branch
from
cbbaa23
to
6cf0596
Compare
|
Checked commit h-kataria@6cf0596 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Sep 17, 2018
There is no need to check for tab title uniqueness for default dashboard (cherry picked from commit 906454b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1621445
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed condition, Only need a check for tab title uniqueness within a group for selected dashboard
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1614872
@yrudman cc
@skateman please review, condition that is being fixed always returns true. This is difficult to recreate, i had to make changes in the database table to be able to recreate. Ping me on gitter, I can help you with that.