Use fonticon+background for powerstate icons in textual summaries #4524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
summary-powerstate
branch
from
1a0d49b
to
7167e91
Compare
|
Checked commit skateman@7167e91 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
skateman
changed the title
epwinchell
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we were using SVG icons for powerstate, however, in the quadicons we already changed this to a fonticon+background combo. This PR brings the same thing for textual summaries 🎉
Note that there might be a floating point issue on certain linux-based browsers (maybe even CPU family related, not sure), however, if you zoom in on the image, it will be perfectly centered.
@miq-bot add_label graphics, textual summaries, gaprindashvili/no
@miq-bot add_reviewer @epwinchell