Fix incorrect title while displaying Datastore details page #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, gaprindashvili/yes |
hstastna
force-pushed
the
Incorrect_title_displaying_Datastore_details
branch
from
217ad32
to
e16b86b
Compare
hstastna
changed the title
hstastna
force-pushed
the
Incorrect_title_displaying_Datastore_details
branch
5 times, most recently
from
a316d17
to
102f475
Compare
hstastna
changed the title
hstastna
changed the title
hstastna
force-pushed
the
Incorrect_title_displaying_Datastore_details
branch
from
da6a365
to
244916e
Compare
hstastna
changed the title
hstastna
changed the title
hstastna
force-pushed
the
Incorrect_title_displaying_Datastore_details
branch
from
244916e
to
d0138c0
Compare
|
Checked commits hstastna/manageiq-ui-classic@82d1469~...ef055df with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
hstastna
changed the title
|
@mzazrivec @martinpovolny Hakiri warning https://hakiri.io/github/ManageIQ/manageiq-ui-classic/master/ef055df2501bf6d1d481c7f4511675c534b0cd01/warnings?name=Dynamic+Render+Path is unrelated to changes in this PR. Looks like it's introduced in #4539 |
|
@h-kataria : @mzazrivec is working on it. We are consulting the best approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1620745
There is a small bug related to Datastores: incorrect title is displayed while displaying Datastore details page: unnecessary 'Names with.. ' and/or 'Filtered by..' is added to the title (right cell text), if any filtering (basic or advanced search) was applied on the list of datastores, before displaying datastore's details page.
Steps to reproduce:
(click on some filter in accordion or use Advanced Search)
Before:
After:
Note:
The fix was inspired by service controller https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/service_controller.rb#L307 and https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/service_controller.rb#L332 which works well.