Show relation "security group belongs to router and subnet" #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as WIP because core PR is not merged yet, otherwise this is ready for review. |
Two foreign keys have been added to the SecurityGroup model recently: ``` security_group.network_router security_group.cloud_subnet ``` With this commit we show them both on UI in both directions. Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
miha-plesko
force-pushed
the
sec-group-belongs-to-router-and-subnet
branch
from
b7bba0a
to
a5f280b
Compare
|
Checked commit miha-plesko@a5f280b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
miha-plesko
changed the title
|
Aaaand the core PR got merged, removing WIP label. |
|
@mzazrivec would you prefer me to split this one into two separate PRs (one per foreign key) to make it easier to review? |
|
@miha-plesko nah, it's fine this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two foreign keys have been added to the SecurityGroup model recently:
With this commit we show them both on UI (in both directions).
SecurityGroup view:
NetworkRouter view:
CloudSubnet view:
Depends on: ManageIQ/manageiq#17900
@miq-bot add_label enhancement
@miq-bot assign @mzazrivec