Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load StorageManagers upon volume creation #4549

Merged
merged 1 commit into from Sep 3, 2018

Commits on Aug 31, 2018

  1. Lazy load StorageManagers upon volume creation

    When creating a new volume user has to pick what StorageManager is volume
    supposed to be created with, hence we perform API request to fetch those.
    Problem is we share angular controller with other volume operations (attach,
    detach) that don't need this list of all managers and fetching those
    anyway results in permission denied error due to fine-grained permission
    setting.
    
    For example if we give user only permission to attach/detach volume, but
    not to view StorageManagers, then we must not perform the API call as it
    results in 403 with red popup.
    
    With this commit we refactor controller so that it now only performs the
    API calls that are really needed.
    
    BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1571224
    
    Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
    miha-plesko committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    771e97f View commit details
    Browse the repository at this point in the history