Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate in tree after class deletion in miq_ae_class_controller #4572

Merged
merged 1 commit into from Sep 6, 2018
Merged

Fix duplicate in tree after class deletion in miq_ae_class_controller #4572

merged 1 commit into from Sep 6, 2018

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Aug 30, 2018 •
edited

Description
A class is still included in the tree after deletion

Solution

The tree was not properly updated after copying, so it can not be refreshed.

Steps to reproduce

  1. Go to Automation -> Automate -> Explorer
  2. Create a namespace, create a domain
  3. Create a class (1) with a name and a display name
  4. Create a class (2) with a name (without a display name)
  5. Copy the second class
  6. Delete the copy
  7. Repeat 5.+6.
  8. You will see the duplicate in the tree

Before
screenshot from 2018-08-30 19-54-46
After
screenshot from 2018-08-30 19-53-45

@miq-bot miq-bot added the wip label Aug 30, 2018
@rvsia rvsia force-pushed the duplicateClassDelete branch 3 times, most recently from 2f5bc86 to cb49f9c Compare September 3, 2018 09:47
@rvsia rvsia changed the title [WIP] Fix duplicate in tree after class deletion in miq_ae_class_controller Fix duplicate in tree after class deletion in miq_ae_class_controller Sep 3, 2018
@rvsia
Copy link
Contributor Author

rvsia commented Sep 3, 2018

@miq-bot add_label gaprindashvili/yes, bug

@rvsia
Copy link
Contributor Author

rvsia commented Sep 3, 2018

@skateman please, review 🙏

@rvsia rvsia changed the title Fix duplicate in tree after class deletion in miq_ae_class_controller [WIP] Fix duplicate in tree after class deletion in miq_ae_class_controller Sep 3, 2018
@miq-bot miq-bot added the wip label Sep 3, 2018
@miq-bot
Copy link
Member

miq-bot commented Sep 4, 2018

Checked commit rvsia@41f77d6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@rvsia rvsia changed the title [WIP] Fix duplicate in tree after class deletion in miq_ae_class_controller Fix duplicate in tree after class deletion in miq_ae_class_controller Sep 4, 2018
@miq-bot miq-bot removed the wip label Sep 4, 2018
@rvsia
Copy link
Contributor Author

rvsia commented Sep 4, 2018

@miq-bot add_label automation/automate

skateman
skateman approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@mzazrivec mzazrivec self-assigned this Sep 6, 2018
@mzazrivec mzazrivec added this to the Sprint 94 Ending Sep 10, 2018 milestone Sep 6, 2018
@mzazrivec mzazrivec merged commit 0ad5178 into ManageIQ:master Sep 6, 2018
@rvsia rvsia deleted the duplicateClassDelete branch September 17, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@mzazrivec mzazrivec

Labels
automation/automate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvsia @miq-bot @skateman @mzazrivec