Login with Service Unavailable - show a flash message instead of generic error popup

[himdel]

Cc @jvlcek

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468252

[himdel]

With invalid login credentials (this is just a 401 request)...

before "Incorrect username or password":

now "Login failed: Unauthorized":

[himdel]

With a 503 error...

before:

+

(the misleading flash message would be visible under the dialog)

now:

(and no popup)

[himdel]

I still don't like that this is giving the user less info, and doesn't mention anything about the possibility of the web services role being disabled.

(Also, it means the login error messages won't be translated (except for the "Login failed" part).)

But it is a simple fix for ...what's apparently a problem, for some reason :)

[miq-bot]

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/0aa9f5b0d95a4cd97ed2d7b1ee9c0167d4a3ea3d~...7317ef49cdaaea6417e6576169d65d60c7c23bb0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

[mzazrivec]

I'm okay with this fix. @jvlcek can I have you endorsement too? 😄

[jvlcek]

I've tested this using upstream master. It works as expected. The fix LGTM

Good job @himdel! Thank you. JoeV