Fixed Schedules accordion swapping logic. #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
changed the title
h-kataria
force-pushed
the
schedule_add_edit_accordion_swap_fix
branch
3 times, most recently
from
b92bba0
to
c3d965a
Compare
Only need to set params[:accord] when add button is pressed from Reports accordion, setting of acord parameter causes acoridon to be swapped to Schedule accordion by Explorer presenter code. Undid code changes made in ManageIQ#3399 this was causing issues when adding a schedule from Reports accordion. Also need to hide form buttons post accordion switch when schedule is added from Reports accordion. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1624248
h-kataria
force-pushed
the
schedule_add_edit_accordion_swap_fix
branch
from
c3d965a
to
62aec06
Compare
|
Checked commit h-kataria@62aec06 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
I know that this is already merged but I tested this anyway. The BZ is not reproducible anymore so I think it works well now. |
|
Needs to be backported to Gaprindashvili to fix https://bugzilla.redhat.com/show_bug.cgi?id=1636744 |
simaishi
pushed a commit
that referenced
this pull request
Nov 5, 2018
…wap_fix Fixed Schedules accordion swapping logic. (cherry picked from commit 0484125) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1646564
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only need to set params[:accord] when add button is pressed from Reports accordion, setting of acord parameter causes acoridon to be swapped to Schedule accordion by Explorer presenter code. Undid code changes made in #3399 this was causing issues when adding a schedule from Reports accordion.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1624248
@hstastna please test/review.
before:
after:
