Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bower to npm: manageiq-ui-components #4694

Merged
merged 2 commits into from Oct 8, 2018
Merged

bower to npm: manageiq-ui-components #4694

merged 2 commits into from Oct 8, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Sep 21, 2018 •
edited

Issue #3734
Depends on #4690

Moves ui-components to npm.

@miq-bot miq-bot changed the title bower to npm: manageiq-ui-components [WIP] bower to npm: manageiq-ui-components Sep 21, 2018
@miq-bot miq-bot added the wip label Sep 21, 2018
@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2018

This pull request is not mergeable. Please rebase and repush.

@himdel himdel mentioned this pull request Oct 5, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2018

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/5d835959e4ed3ee476c571112df6d8b23962f520~...94b60c483e32328762dfc743289d2080da957d02 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@himdel himdel mentioned this pull request Oct 5, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2018

This pull request is not mergeable. Please rebase and repush.

@himdel himdel removed the unmergeable label Oct 8, 2018
@himdel
Copy link
Contributor Author

himdel commented Oct 8, 2018

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] bower to npm: manageiq-ui-components bower to npm: manageiq-ui-components Oct 8, 2018
@miq-bot miq-bot removed the wip label Oct 8, 2018
@himdel
Make sure specs don't fail on empty bower_components
cfdecc6 
this is done properly in #4735
but travis won't pass otherwise with no bower deps
himdel
himdel commented Oct 8, 2018
View reviewed changes
tools/ci/setup_js_env.sh
@@ -20,7 +20,7 @@ else

# fail the whole test suite if bower install failed
[ $STATUS = 0 ] || exit 1
[ -d vendor/assets/bower/bower_components ] || exit 1
#[ -d vendor/assets/bower/bower_components ] || exit 1
Copy link
Contributor Author

@himdel himdel Oct 8, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Removed properly in https://github.com/ManageIQ/manageiq-ui-classic/pull/4735/files#diff-df544bbd5873f755dd4d52d7a6bad0dfL23 (#4735))

@mzazrivec mzazrivec self-assigned this Oct 8, 2018
@mzazrivec mzazrivec added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 8, 2018
@mzazrivec mzazrivec merged commit 5ed9e2f into ManageIQ:master Oct 8, 2018
@himdel himdel deleted the npm-ui-components branch October 8, 2018 14:36
simaishi pushed a commit that referenced this pull request Oct 8, 2018
@mzazrivec @simaishi
Merge pull request #4694 from himdel/npm-ui-components
937f263 
bower to npm: manageiq-ui-components

(cherry picked from commit 5ed9e2f)
@simaishi
Copy link
Contributor

simaishi commented Oct 8, 2018

Hammer backport details:

$ git log -1
commit 937f2632ced005ce62ee87022e64f25385f4d43c
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Oct 8 16:35:37 2018 +0200

    Merge pull request #4694 from himdel/npm-ui-components
    
    bower to npm: manageiq-ui-components
    
    (cherry picked from commit 5ed9e2fbd86dcde5d7cd8858394460f76e0baa7e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
dependencies hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@himdel @miq-bot @simaishi @mzazrivec