Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fonticons for orphaned/retired machine state instead of text #4701

Merged
merged 1 commit into from Sep 26, 2018

Conversation

skateman
Copy link
Member

Analogous with #4678 and possible thanks to ManageIQ/font-fabulous#52.

Before:
screenshot from 2018-09-25 09-13-44

After:
screenshot from 2018-09-25 09-16-00

Note that the retired VM is usually not available in any DB as it will immediately move into the orphaned state after the retiring is complete. However, it will show up in genealogy that will be addressed in a followup PR.

@miq-bot add_reviewer @epwinchell
@miq-bot add_label graphics, GTLs, hammer/yes, gaprindashvili/no

@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2018

@skateman Cannot apply the following label because they are not recognized: hammer/yes

@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2018

Checked commit skateman@f820d6f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 0 offenses detected
Everything looks fine. 🏆

@skateman
Copy link
Member Author

@miq-bot assign @mzazrivec

@skateman
Copy link
Member Author

@miq-bot add_label hammer/yes

@h-kataria h-kataria assigned h-kataria and unassigned mzazrivec Sep 26, 2018
@h-kataria h-kataria added this to the Sprint 96 Ending Oct 8, 2018 milestone Sep 26, 2018
@h-kataria h-kataria merged commit 751657d into ManageIQ:master Sep 26, 2018
@skateman skateman deleted the ff-state-icons branch September 26, 2018 13:22
simaishi pushed a commit that referenced this pull request Sep 26, 2018
Use fonticons for orphaned/retired machine state instead of text

(cherry picked from commit 751657d)
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit f78d3eb9e0f37ba7dc41274d827420cb19e31823
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Sep 26 09:22:28 2018 -0400

    Merge pull request #4701 from skateman/ff-state-icons
    
    Use fonticons for orphaned/retired machine state instead of text
    
    (cherry picked from commit 751657d97df3263dc20f3ade5e560c399f7d3930)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants