Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete obsolete power state images #4707

Merged
merged 1 commit into from Sep 27, 2018
Merged

Delete obsolete power state images #4707

merged 1 commit into from Sep 27, 2018

Conversation

epwinchell
Copy link
Contributor

Follow-up to: #4616

@epwinchell
Copy link
Contributor Author

@miq-bot add_labels gaprindashvili/no, graphics, hammer/yes

@epwinchell
Copy link
Contributor Author

@miq-bot add_reviewer @skateman

@miq-bot
Copy link
Member

miq-bot commented Sep 26, 2018

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/e361d547ef63bb8f244cfb49b20fd7b1e90b0e24 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

skateman
skateman approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@skateman
Copy link
Member

@miq-bot assign @h-kataria

@h-kataria h-kataria added this to the Sprint 96 Ending Oct 8, 2018 milestone Sep 27, 2018
@h-kataria h-kataria merged commit 1e009a8 into ManageIQ:master Sep 27, 2018
@skateman skateman deleted the powerstate_cleanup branch September 27, 2018 19:21
simaishi pushed a commit that referenced this pull request Oct 1, 2018
@h-kataria @simaishi
Merge pull request #4707 from epwinchell/powerstate_cleanup
3b05afc 
Delete obsolete power state images

(cherry picked from commit 1e009a8)
@simaishi
Copy link
Contributor

simaishi commented Oct 1, 2018

Hammer backport details:

$ git log -1
commit 3b05afc3efa400f1197297655da2812fc261650e
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Sep 27 12:08:46 2018 -0400

    Merge pull request #4707 from epwinchell/powerstate_cleanup
    
    Delete obsolete power state images
    
    (cherry picked from commit 1e009a86fde02d5e66d4ee55f47914e0e94445c4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@h-kataria h-kataria

Labels
graphics hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@epwinchell @miq-bot @skateman @simaishi @h-kataria