Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove full_ids from infra networking tree to fix error in selection #4727

Merged
merged 1 commit into from Oct 4, 2018
Merged

Remove full_ids from infra networking tree to fix error in selection #4727

merged 1 commit into from Oct 4, 2018

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Oct 3, 2018 •
edited

Steps to reproduce:
Compute -> Infrastructure -> Networking -> select a switch in summary of another node like root

(You need to have some Switch with shared set to true.)

Before:
Switch node isn't selected but summary of the switch is displayed
screen shot 2018-10-03 at 12 07 03 pm

After:
Summary and selected node match each other.
screen shot 2018-10-03 at 12 05 17 pm

@miq-bot add_label bug, trees

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1460992

@miq-bot
Copy link
Member

miq-bot commented Oct 3, 2018

Checked commit ZitaNemeckova@2f3ddab with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

romanblanco
romanblanco approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in UI, fixes the bug 👍

@mzazrivec mzazrivec self-assigned this Oct 4, 2018
@mzazrivec mzazrivec added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 4, 2018
@mzazrivec mzazrivec merged commit 1b1f38e into ManageIQ:master Oct 4, 2018
simaishi pushed a commit that referenced this pull request Oct 4, 2018
@mzazrivec @simaishi
Merge pull request #4727 from ZitaNemeckova/networking_without_full_ids
31a2bd9 
Remove full_ids from infra networking tree to fix error in selection

(cherry picked from commit 1b1f38e)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1460992
@simaishi
Copy link
Contributor

simaishi commented Oct 4, 2018

Hammer backport details:

$ git log -1
commit 31a2bd9f5445802694613f2ccd93b373baee0590
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Oct 4 12:18:31 2018 +0200

    Merge pull request #4727 from ZitaNemeckova/networking_without_full_ids
    
    Remove full_ids from infra networking tree to fix error in selection
    
    (cherry picked from commit 1b1f38e568c29ae7c40e2aac55866f7fc6813737)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1460992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanblanco romanblanco romanblanco approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug hammer/backported trees
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZitaNemeckova @miq-bot @simaishi @romanblanco @mzazrivec