Made changes to save server name only if it is not blank #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
dont_allow_blank_appliance_name_for_server
branch
from
320203a
to
db267f4
Compare
|
@h-kataria can you try to fix the CC issue? |
h-kataria
force-pushed
the
dont_allow_blank_appliance_name_for_server
branch
from
db267f4
to
975f5dd
Compare
Also fixed the check that compares previously saved value against the value from miq_server record instead of checking `@update.config[:server][:name]` server/name key did not exist in settings.yml so the condition always returned true. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1634518
h-kataria
force-pushed
the
dont_allow_blank_appliance_name_for_server
branch
from
975f5dd
to
9680941
Compare
|
Checked commit h-kataria@9680941 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/controllers/ops_controller/settings/common.rb
|
|
@dclarizio fixed cc issue. |
simaishi
pushed a commit
that referenced
this pull request
Oct 4, 2018
…me_for_server Made changes to save server name only if it is not blank (cherry picked from commit 5078295) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1634518
|
Hammer backport details: |
|
backporting this PR to Gaprindashvili, should fix https://bugzilla.redhat.com/show_bug.cgi?id=1635178 |
|
@h-kataria Both files conflict backporting to Gaprindashvili branch. Please create a separate PR |
|
Backported to Gaprindashvili via #4876 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed the check that compares previously saved value against the value from miq_server record instead of checking
@update.config[:server][:name]server/name key did not exist in settings.yml so the condition always returned true.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1634518
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635178
@yrudman please test