Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for javascript error when attempting to edit a service dialog based on orchestration template #4759

Merged
merged 1 commit into from Oct 11, 2018

Conversation

eclarizio
Copy link
Member

The issue states that there was an infinite spinner when clicking on the dialog to edit in the Automate -> Customization section, which uses the sample page to initially show the dialog. However, the sample page has no reason to call the offending method initializeDialogSelectPicker since that method sets up the field to call to a url and/or trigger refreshes which make no sense on the sample page. Thus, we should simply use miqInitSelectPicker to give us the patternfly styling we want without the unnecessary setup.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638420

@miq-bot assign @h-kataria
@miq-bot add_label bug

@h-kataria
Copy link
Contributor

verified fix.

@h-kataria h-kataria self-assigned this Oct 11, 2018
@h-kataria h-kataria added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 11, 2018
@h-kataria h-kataria merged commit 6f48f14 into ManageIQ:master Oct 11, 2018
simaishi pushed a commit that referenced this pull request Oct 12, 2018
Fix for javascript error when attempting to edit a service dialog based on orchestration template

(cherry picked from commit 6f48f14)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638420
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 81f32e3b3e7e49c43d0264871645d919be840d05
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Oct 11 17:55:34 2018 -0400

    Merge pull request #4759 from eclarizio/BZ1638420
    
    Fix for javascript error when attempting to edit a service dialog based on orchestration template
    
    (cherry picked from commit 6f48f1410207d8d9817435d6de4c1bf08fe78f2e)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants