Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save server's zone name in @edit[:new] #4784

Closed

Conversation

h-kataria
Copy link
Contributor

This was preventing from Save button to be enabled when only Server's zone name was changed on the server settings screen.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1639877

@mzazrivec
Copy link
Contributor

The spec failure seems related:

NameError:
       uninitialized constant VMDB::Config
     # ./spec/controllers/ops_controller/settings/common_spec.rb:446:in `block (5 levels) in <top (required)>'

@h-kataria h-kataria force-pushed the fix_saving_server_zone_name branch 2 times, most recently from 493f3e8 to 1edfb2f Compare October 17, 2018 14:35
This was preventing from Save button to be enabled when only Server's zone name was changed on the server settings screen.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1639877
@miq-bot
Copy link
Member

miq-bot commented Oct 17, 2018

Checked commit h-kataria@d39a97e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@skateman
Copy link
Member

@h-kataria can you show this to me on bluejeans? The BZ description is not very helpful, it seems like it works for me even without applying your patch.

@h-kataria
Copy link
Contributor Author

Closing this PR in favor of backporting #4072 to Gaprindashvili
Verified this issue does not exist on Hammer and current master branches.

@h-kataria h-kataria closed this Oct 18, 2018
@h-kataria h-kataria deleted the fix_saving_server_zone_name branch October 24, 2018 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants