Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase limit of email text field to 254 characters #4826

Merged
merged 1 commit into from Oct 26, 2018

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Oct 25, 2018

Fixes #3677

The emails are limited to 51 characters, however they can be 254 characters long (according to documentation mentioned in the issue). Of course I don't think there could be anyone with so long email address, but it's not a bad idea to support it.

@miq-bot add_label hammer/no, rbac,

@miq-bot
Copy link
Member

miq-bot commented Oct 25, 2018

Checked commit rvsia@e15d1d6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec mzazrivec self-assigned this Oct 26, 2018
@mzazrivec mzazrivec added this to the Sprint 98 Ending Nov 5, 2018 milestone Oct 26, 2018
@mzazrivec mzazrivec merged commit ae43266 into ManageIQ:master Oct 26, 2018
@rvsia rvsia deleted the email_too_short branch September 17, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants