Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show cross linking containers links #484

Merged
merged 1 commit into from Apr 5, 2017
Merged

Show cross linking containers links #484

merged 1 commit into from Apr 5, 2017

Conversation

rubenvp8510
Copy link
Contributor

screenshot from 2017-02-23 00-44-26

mzazrivec
mzazrivec suggested changes Feb 27, 2017
View reviewed changes
app/helpers/middleware_server_helper/textual_summary.rb Outdated
lives_on_entity_name = _("Virtual Machine")

if lives_on.kind_of?(Container)
lives_on_entity_name = _("Container")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be having the whole label here, not just the entity name. I.e.:

label = _("Underlying Container")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I'll do the change.

@mzazrivec mzazrivec self-assigned this Feb 27, 2017
@rubenvp8510
Copy link
Contributor Author

This PR depends on : ManageIQ/manageiq#14043

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2017

Checked commit rubenvp8510@2c5fd74 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@bronaghs
Copy link

@miq-bot add_label middleware

@mtho11
Copy link
Contributor

mtho11 commented Feb 27, 2017

@miq-bot add_label ui, enhancement

@mzazrivec mzazrivec modified the milestone: Sprint 56 Ending Mar 13, 2017 Mar 4, 2017
@dclarizio dclarizio removed the ui label Mar 13, 2017
abonas
abonas reviewed Mar 19, 2017
View reviewed changes
app/helpers/middleware_server_helper/textual_summary.rb
{
:label => "Underlying #{lives_on_entity_name}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is "underlying" not reused as previously? now it is repeated in line 70 and in line 73

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explained in a conversation above.

@abonas
Copy link
Member

abonas commented Mar 27, 2017

@rubenvp8510 @mzazrivec Is the review for this patch completed? it still says "changes requested", but it looks like all comments were addressed

@abonas
Copy link
Member

abonas commented Apr 3, 2017

@rubenvp8510 @mzazrivec Is the review for this patch completed? it still says "changes requested", but it looks like all comments were addressed

@rubenvp8510
Copy link
Contributor Author

@abonas from my point of view this is completed and ready for merge, I've already addressed the comments of @mzazrivec.

@mzazrivec Is there more comments for this PR?

@abonas
Copy link
Member

abonas commented Apr 5, 2017

@mzazrivec @martinpovolny @bronaghs if someone can review/ack this please

@mzazrivec mzazrivec added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 5, 2017
@mzazrivec mzazrivec merged commit f2837ad into ManageIQ:master Apr 5, 2017
@abonas
Copy link
Member

abonas commented May 3, 2017

@miq-bot add_label fine/yes
@simaishi @chrispy1, it was not labeled for fine although it should be in fine - it is part of a "must to have" feature (we need to have some process ensuring things are labeled properly and not forgotten, especially since different teams are reviewing, acking and merging)

@simaishi
Copy link
Contributor

simaishi commented May 3, 2017

@rubenvp8510 @abonas we need a BZ to get this into Fine. Please create one if it doesn't exist.

@abonas
Copy link
Member

abonas commented May 3, 2017 •
edited

@rubenvp8510 please see @simaishi comment. I was not sure if there's a BZ or only a JMAN? If no BZ, please create one and link it here

@abonas
Copy link
Member

abonas commented May 4, 2017

@simaishi I added this BZ for backporting https://bugzilla.redhat.com/show_bug.cgi?id=1448070

@chrispy1
Copy link

chrispy1 commented May 4, 2017

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label May 4, 2017
simaishi pushed a commit that referenced this pull request May 4, 2017
@mzazrivec @simaishi
Merge pull request #484 from rubenvp8510/xlinking
7236ecf 
Show cross linking containers links
(cherry picked from commit f2837ad)

https://bugzilla.redhat.com/show_bug.cgi?id=1448131
@simaishi
Copy link
Contributor

simaishi commented May 4, 2017

Fine backport details:

$ git log -1
commit 7236ecf8a6d0dfdeed426a9923cd558fd5927f3e
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Apr 5 15:25:20 2017 +0200

    Merge pull request #484 from rubenvp8510/xlinking
    
    Show cross linking containers links
    (cherry picked from commit f2837ad74ccd7973877da507097c8a38c54f7acd)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1448131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonas abonas abonas left review comments

@mzazrivec mzazrivec mzazrivec approved these changes

Assignees

@mzazrivec mzazrivec

Labels
blocker enhancement fine/backported middleware pending core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rubenvp8510 @miq-bot @bronaghs @mtho11 @abonas @simaishi @chrispy1 @mzazrivec @dclarizio