Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dialog only for "Display for" set to "Single" #4865

Merged
merged 1 commit into from Nov 5, 2018

Conversation

ZitaNemeckova
Copy link
Contributor

Closes #4142

Go to Automate -> Automation -> Custumization -> Buttons -> create/edit one -> set Dialog to something -> set Display for to List or Single and List-> save it

Before:
screen shot 2018-11-02 at 12 44 28 pm

After:
screen shot 2018-11-02 at 12 07 03 pm

Also sets Dialog to nil when List or Single and List is selected.

@miq-bot add_label bug, hammer/no

@romanblanco please review, thanks :)

@miq-bot
Copy link
Member

miq-bot commented Nov 2, 2018

Checked commit ZitaNemeckova@eeffd20 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec mzazrivec self-assigned this Nov 5, 2018
@mzazrivec mzazrivec added this to the Sprint 98 Ending Nov 5, 2018 milestone Nov 5, 2018
@mzazrivec mzazrivec merged commit af51ff0 into ManageIQ:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants