Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset session on failed CSRF token verification #4901

Conversation

mzazrivec
Copy link
Contributor

  1. Navigate to Compute ➛ Infrastructure ➛ Providers ➛ choose a provider ➛ provider summary page
  2. Clear memcached
  3. On the provider summary page, click on refresh

Before, the failed CSRF token validation would render an exception.

With this fix in place, failed CSRF token validation will void the session and redirect user to login screen.

https://bugzilla.redhat.com/show_bug.cgi?id=1642948

@miq-bot
Copy link
Member

miq-bot commented Nov 9, 2018

Checked commit mzazrivec@6e1f59c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@martinpovolny
Copy link

A test will be added in a follow up PR (due to PTO).

@martinpovolny martinpovolny self-assigned this Nov 12, 2018
@martinpovolny martinpovolny added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 12, 2018
@martinpovolny martinpovolny merged commit 3cc5463 into ManageIQ:master Nov 12, 2018
simaishi pushed a commit that referenced this pull request Nov 12, 2018
…verification

Reset session on failed CSRF token verification

(cherry picked from commit 3cc5463)

https://bugzilla.redhat.com/show_bug.cgi?id=1642948
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit f6cec839f59ffaefe4512d4963dc481aa15af7ae
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Mon Nov 12 15:58:40 2018 +0100

    Merge pull request #4901 from mzazrivec/reset_session_on_failed_csrf_verification
    
    Reset session on failed CSRF token verification
    
    (cherry picked from commit 3cc54630a252433ac8ab0a920dc352038c06bcd6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1642948

@mzazrivec mzazrivec deleted the reset_session_on_failed_csrf_verification branch November 19, 2018 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants