fix icon font family class

[epwinchell]

Several PF font icons were using the "fa" class instead of "pficon" for some reason. It works fine on master but is broken when doing PF4 testing. This PR corrects that.

[epwinchell]

@miq-bot add_label bug, hammer/no

[epwinchell]

@miq-bot assign @himdel

[himdel]

Makes sense, but I'm seeing a bunch more @epwinchell ...

$ ag fa.*pficon
app/decorators/miq_action_decorator.rb
19:      'fa pficon-cpu'

app/helpers/application_helper/toolbar/ems_container_center.rb
23:          'fa pficon-import fa-lg',

app/helpers/application_helper/toolbar/ems_containers_center.rb
21:          'fa pficon-import fa-lg',

app/helpers/application_helper/toolbar/ems_physical_infra_center.rb
83:      'fa pficon-screen fa-lg',

app/helpers/application_helper/toolbar/container_project_view.rb
22:      'fa pficon-topology',

app/helpers/application_helper/toolbar/x_vm_center.rb
253:      'fa pficon-screen fa-lg',

app/helpers/application_helper/toolbar/physical_server_center.rb
113:        'fa pficon-screen fa-lg',

app/helpers/application_helper/toolbar/cloud/instance_operations_button_group_mixin.rb
106:        'fa pficon-screen fa-lg',

app/helpers/application_helper/toolbar/dashboard_summary_toggle_view.rb
22:      'fa pficon-topology',

app/helpers/application_helper/toolbar/stack_orchestration_template_center.rb
23:          'fa pficon-info fa-lg',

[epwinchell]

@miq-bot add_label wip

[epwinchell]

@miq-bot rm_label wip

[miq-bot]

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/48e6e45b3ccc08f2f9b26eab079b4971528086f5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
12 files checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[himdel]

LGTM, I'm not seeing any more of these :)

(also checked for fa + ff-, and fa + glyphicon)