New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed reading of ems_refresh_threshold memory_threshold value #4925
Merged
dclarizio
merged 1 commit into
ManageIQ:master
from
h-kataria:fixed_reading_of_refresh_worker_memory_threshold_value
Nov 14, 2018
Merged
Fixed reading of ems_refresh_threshold memory_threshold value #4925
dclarizio
merged 1 commit into
ManageIQ:master
from
h-kataria:fixed_reading_of_refresh_worker_memory_threshold_value
Nov 14, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
changed the title
Fixed reading of ems_refresh_threshold memory_threshold value
[WIP] - Fixed reading of ems_refresh_threshold memory_threshold value
Nov 14, 2018
Checked commit h-kataria@e8c9205 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
lgalis
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
h-kataria
changed the title
[WIP] - Fixed reading of ems_refresh_threshold memory_threshold value
Fixed reading of ems_refresh_threshold memory_threshold value
Nov 14, 2018
@h-kataria there is a conflict backporting to Hammer branch. Please create a separate PR. diff --cc app/views/ops/_settings_workers_tab.html.haml
index dba287dd1,bfa1f4b8f..000000000
--- a/app/views/ops/_settings_workers_tab.html.haml
+++ b/app/views/ops/_settings_workers_tab.html.haml
@@@ -207,7 -207,7 +207,11 @@@
.col-md-8
= select_tag('ems_refresh_worker_threshold',
options_for_select(@sb[:ems_refresh_threshold],
++<<<<<<< HEAD
+ @edit[:new].get_raw_worker_setting(:MiqEmsRefreshWorker, :memory_threshold)),
++=======
+ @edit[:new][:workers][:worker_base][:queue_worker_base][:ems_refresh_worker][:defaults][:memory_threshold]),
++>>>>>>> c37d42cef... Merge pull request #4925 from h-kataria/fixed_reading_of_refresh_worker_memory_threshold_value
:class => "selectpicker")
:javascript
miqSelectPickerEvent('ems_refresh_worker_threshold', "#{url}") |
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 16, 2018
Backported to Hammer via #4931 |
h-kataria
deleted the
fixed_reading_of_refresh_worker_memory_threshold_value
branch
April 9, 2019 22:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649799
Value was getting saved properly but need to point to right key in the hash while reading it back to populate the drop down with correct saved value