Remove S3 and Swift From List of Log Collection Types #4926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of log collection types is currently built by pulling in all valid FileDepot types. Unfortunately, while AWS S3 and OpenStack Swift were added as FileDepots for Database backups, no work was done for Log Collection via these depots. When the list of valid types is built in the UI therefore, these two need to be removed.
|
Checked commit jerryk55@7211027 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
verified in UI |
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2018
Remove S3 and Swift From List of Log Collection Types (cherry picked from commit 9043ee0) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1643966
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of log collection types is currently built by pulling in all valid FileDepot types.
Unfortunately, while AWS S3 and OpenStack Swift were added as FileDepots for Database backups,
no work was done for Log Collection via these depots. When the list of valid types is built in the
UI therefore, these two need to be removed.
Before:
After:
@h-kataria please review and merge when appropriate. Feel free to add other reviewers as necessary. Thanks.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1643966
Links