Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM CLoud: floating ips to associate must be a list #4944

Merged
merged 1 commit into from Nov 20, 2018
Merged

VM CLoud: floating ips to associate must be a list #4944

merged 1 commit into from Nov 20, 2018

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Nov 20, 2018 •
edited by simaishi

Fix drop down list of floating IPs.
Using where to return a list versus find_by which return only one item

https://bugzilla.redhat.com/show_bug.cgi?id=1595767

@gildub
Copy link
Contributor Author

gildub commented Nov 20, 2018

@miq-bot add_label hammer/yes, gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Nov 20, 2018

Checked commit https://github.com/gildub/manageiq-ui-classic/commit/4102504c1db393b1cce97a9bd901591f9c546283 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec self-assigned this Nov 20, 2018
@mzazrivec mzazrivec added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 20, 2018
@mzazrivec mzazrivec merged commit 911a289 into ManageIQ:master Nov 20, 2018
simaishi pushed a commit that referenced this pull request Nov 20, 2018
@mzazrivec @simaishi
Merge pull request #4944 from gildub/vm_cloud_floating_ip
bf21dad 
VM CLoud: floating ips to associate must be a list

(cherry picked from commit 911a289)

https://bugzilla.redhat.com/show_bug.cgi?id=1595767
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit bf21dadc0908531b7ca2cf0397ea2a23b35cc8c6
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Nov 20 12:37:41 2018 +0100

    Merge pull request #4944 from gildub/vm_cloud_floating_ip
    
    VM CLoud: floating ips to associate must be a list
    
    (cherry picked from commit 911a289574b1d433c6a8fcde890ebb39d7f24da2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1595767

@gildub gildub deleted the vm_cloud_floating_ip branch November 20, 2018 23:03
simaishi pushed a commit that referenced this pull request Nov 21, 2018
@mzazrivec @simaishi
Merge pull request #4944 from gildub/vm_cloud_floating_ip
0758123 
VM CLoud: floating ips to associate must be a list

(cherry picked from commit 911a289)

https://bugzilla.redhat.com/show_bug.cgi?id=1623562
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 075812394abf5137e6c92f70b4fc3ac40b157c21
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Nov 20 12:37:41 2018 +0100

    Merge pull request #4944 from gildub/vm_cloud_floating_ip
    
    VM CLoud: floating ips to associate must be a list
    
    (cherry picked from commit 911a289574b1d433c6a8fcde890ebb39d7f24da2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1623562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
blocker bug compute/cloud gaprindashvili/backported hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gildub @miq-bot @simaishi @mzazrivec