Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When redirecting to a specific storage, RBAC check storage_show #5004

Merged
merged 1 commit into from Nov 29, 2018

Conversation

skateman
Copy link
Member

When accessing the datastores of a given provider as a user of the EvmGroup-operator group, the RBAC check fails because it is invalid. Testing against the top level feature for a non-admin will always return nil and also it doesn't even describe the operation properly. The correct feature to test against is storage_show, so I'm replacing it. cc @PanSpagetka this was implemented by you

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653709

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Nov 28, 2018
@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2018

Checked commit skateman@7974931 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Nov 29, 2018
@mzazrivec mzazrivec added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 29, 2018
@mzazrivec mzazrivec merged commit 81e2fee into ManageIQ:master Nov 29, 2018
@skateman skateman deleted the rbac-datastore branch November 29, 2018 07:55
simaishi pushed a commit that referenced this pull request Dec 3, 2018
When redirecting to a specific storage, RBAC check storage_show

(cherry picked from commit 81e2fee)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653709
@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2018

Hammer backport details:

$ git log -1
commit 5bf80a07dd490492948948574b44d600bf369ff0
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Nov 29 08:42:52 2018 +0100

    Merge pull request #5004 from skateman/rbac-datastore
    
    When redirecting to a specific storage, RBAC check storage_show
    
    (cherry picked from commit 81e2feea9f83f03756c2effc0d740680e6ee80ff)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants