New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
select: use @pf3/select instead of bootstrap-select #5029
Conversation
wip because we probably need a webpack alias to replace other packages doing require bootstrap select (done) |
this replaces bootstrap-select 1.12.2 with 1.12.6, except that 1.12.6 comes from my fork, as upstream is nonresponsive Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648115
@pf3/select is bootstrap-select, except maintained by me force patternfly to use that, instead of proper bootstrap-select
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/120e42c8a0339e531c8d87b07e182e4f34f3fe90~...864fe801ef4f14c7f54e0338ebfdf847a1a516f0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@himdel I'm a little confused about the source of the package. The global s.js is |
@Fryguy Right, the npm namespace is indeed I've started the This is the second package in that namespace, Seems like this is going to be happening more and more, so I'm actually considering going through all the packages systematically, removing all the usual crud (bower & composer support, complicated grunt/gulp build scripts, git-commited EDIT: to be clear, this is only about patternfly's bootstrap/jquery set of dependencies (and partly angular1). The React parts are mostly alive and well (well, with the caveat that big chunks of patternfly-react are built on obsolete react-bootstrap, but, that's another issue entirely :)). |
@himdel thanks for the detail. I was originally asking because maybe it's better to put that in the ManageIQ org or perhaps a brand new org. We generally try to avoid personal repos with things we have to own as a project. |
Aah, right.. that might definitely make sense.. I'll get those repos ready and ping you, looks like I have 4 now:
|
@himdel For hammer branch, yarn.lock needs to be updated as well, I assume? |
Agreed @simaishi, should I create a separate PR? |
@himdel yes, please. Either this PR + lock OR just lock (and I'll backport this PR) - whichever is easier for you 😄 |
Backported to Hammer via #5073 |
this replaces bootstrap-select 1.12.2 with 1.12.5,
except that 1.12.5 comes from my fork, as upstream is nonresponsive
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648115
EDIT: 1.12.6, 5 had bad paths in dist/
The practical difference should be himdel/bootstrap-select#1 :
multiselect with search should not scroll up to the search bar whenever an item is chosen in the dropdown, when data-live-search-focus is set to false.
This also sets
data-live-search-focus
to false for available fields in the Report form, fixing the BZ :).