Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select: use @pf3/select instead of bootstrap-select #5029

Merged
merged 3 commits into from Dec 4, 2018
Merged

select: use @pf3/select instead of bootstrap-select #5029

merged 3 commits into from Dec 4, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Dec 3, 2018

this replaces bootstrap-select 1.12.2 with 1.12.5,
except that 1.12.5 comes from my fork, as upstream is nonresponsive

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648115

EDIT: 1.12.6, 5 had bad paths in dist/


The practical difference should be himdel/bootstrap-select#1 :

multiselect with search should not scroll up to the search bar whenever an item is chosen in the dropdown, when data-live-search-focus is set to false.


This also sets data-live-search-focus to false for available fields in the Report form, fixing the BZ :).

@himdel himdel changed the title select: use @pf3/select instead of bootstrap-select [WIP] select: use @pf3/select instead of bootstrap-select Dec 3, 2018
@himdel
Copy link
Contributor Author

himdel commented Dec 3, 2018

wip because we probably need a webpack alias to replace other packages doing require bootstrap select

(done)

this replaces bootstrap-select 1.12.2 with 1.12.6,
except that 1.12.6 comes from my fork, as upstream is nonresponsive

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648115
@pf3/select is bootstrap-select, except maintained by me
force patternfly to use that, instead of proper bootstrap-select
@himdel himdel removed the wip label Dec 3, 2018
@himdel himdel changed the title [WIP] select: use @pf3/select instead of bootstrap-select select: use @pf3/select instead of bootstrap-select Dec 3, 2018
@himdel
Copy link
Contributor Author

himdel commented Dec 3, 2018

Testing:

CI > Reports > Reports ... Configuration > Add a new Report
base on almost anything normal
pick a field thats near the bottom of the list, click it

before: the list will scroll back up:
20181121123244_magic

now: it will stay on the field you selected

@miq-bot
Copy link
Member

miq-bot commented Dec 3, 2018

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/120e42c8a0339e531c8d87b07e182e4f34f3fe90~...864fe801ef4f14c7f54e0338ebfdf847a1a516f0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Dec 4, 2018
@mzazrivec mzazrivec added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 4, 2018
@mzazrivec mzazrivec merged commit ccb008c into ManageIQ:master Dec 4, 2018
@himdel himdel deleted the pf3select branch December 4, 2018 15:18
@Fryguy
Copy link
Member

Fryguy commented Dec 6, 2018

@himdel I'm a little confused about the source of the package. The global s.js is @pf3, but then you mention your own fork for the source (or was that just a demonstration reference)

@himdel
Copy link
Contributor Author

himdel commented Dec 7, 2018

@Fryguy Right, the npm namespace is indeed @pf3, but the source is my fork, at https://github.com/himdel/bootstrap-select.

I've started the @pf3 namespace as a kind of unofficial place to gather all of patternfly 3's dead dependencies.

This is the second package in that namespace, patternfly-timeline has had no reactions on issues for a year, so that was the first one I forked.

Seems like this is going to be happening more and more, so I'm actually considering going through all the packages systematically, removing all the usual crud (bower & composer support, complicated grunt/gulp build scripts, git-commited dist/, different versions of UMD/AMD/... loaders with various degrees of compatibility with current browser/webpack environments, etc.), fixing the usual broken dependencies (for example, most npm packages which depend on jquery are plain wrong because that should be a peerDependency, otherwise you can end up with using multiple different jquery versions), etc, etc. ... and creating a patternfly 3 distribution that just pulls those cleaned up sources and builds it once. (Incidentally, that should save us about a minute of webpack time per compile.)

EDIT: to be clear, this is only about patternfly's bootstrap/jquery set of dependencies (and partly angular1). The React parts are mostly alive and well (well, with the caveat that big chunks of patternfly-react are built on obsolete react-bootstrap, but, that's another issue entirely :)).

@Fryguy
Copy link
Member

Fryguy commented Dec 8, 2018

@himdel thanks for the detail. I was originally asking because maybe it's better to put that in the ManageIQ org or perhaps a brand new org. We generally try to avoid personal repos with things we have to own as a project.

@himdel
Copy link
Contributor Author

himdel commented Dec 10, 2018

Aah, right.. that might definitely make sense.. I'll get those repos ready and ping you, looks like I have 4 now:

  • @pf3/timeline
  • @pf3/select
  • spice-html5-bower
  • jquery.observe_field

@simaishi
Copy link
Contributor

@himdel For hammer branch, yarn.lock needs to be updated as well, I assume?

@himdel
Copy link
Contributor Author

himdel commented Dec 10, 2018

Agreed @simaishi, should I create a separate PR?

@simaishi
Copy link
Contributor

@himdel yes, please. Either this PR + lock OR just lock (and I'll backport this PR) - whichever is easier for you 😄

@himdel
Copy link
Contributor Author

himdel commented Dec 11, 2018

@simaishi #5073 should be ready (and replaces this one for hammer)

@simaishi
Copy link
Contributor

Backported to Hammer via #5073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants