Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use widget's title in flash messages #5047

Merged

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Dec 5, 2018

Use widget's title in flash messages

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656413

BEFORE:
before

AFTER:
after

@miq-bot add-label bug, cloud intel/reporting

@miq-bot
Copy link
Member

miq-bot commented Dec 5, 2018

Checked commit yrudman@2dd0e7d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Dec 6, 2018
@mzazrivec mzazrivec added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 6, 2018
@mzazrivec mzazrivec merged commit 05165ae into ManageIQ:master Dec 6, 2018
@yrudman
Copy link
Contributor Author

yrudman commented Dec 6, 2018

@miq-bot add-label blocker

@yrudman yrudman deleted the use-widget-title-in-flas-messages branch December 6, 2018 13:07
@miq-bot miq-bot added the blocker label Dec 6, 2018
simaishi pushed a commit that referenced this pull request Dec 6, 2018
@simaishi
Copy link
Contributor

simaishi commented Dec 6, 2018

Hammer backport details:

$ git log -1
commit 8173dab6fd4566efb95f9879e872e070272206a2
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Dec 6 08:11:18 2018 +0100

    Merge pull request #5047 from yrudman/use-widget-title-in-flas-messages
    
    Use widget's title in flash messages
    
    (cherry picked from commit 05165ae60ad8851a1a5fd78f16851294883ca97f)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants