Region Replication - refresh code mirror after load #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when replication type is already set to Remote, the code mirror component renders too soon and thus renders without data adding an explicit ui-refresh, to trigger a refresh once the data is loaded Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656066
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/e1bdeac135504f4e69b61dc98351161dece2674e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
simaishi
pushed a commit
that referenced
this pull request
Apr 23, 2019
Region Replication - refresh code mirror after load (cherry picked from commit a55668e) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702486
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(admin) > Configuration > CFME Region > Replication
when replication type is already set to Remote,
the code mirror component renders too soon and thus renders without data
(this does not happen when the user explicitly changes to Remote)
adding an explicit ui-refresh, to trigger a refresh once the data is loaded
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656066