Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1650484: Update misleading form label for new Cloud Tenant form #5127

Merged
merged 1 commit into from Jan 7, 2019

Conversation

sseago
Copy link
Contributor

@sseago sseago commented Jan 7, 2019

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650484

The prior version of this labeled the field "Cloud Provider", but the
actual field content includes both cloud providers and cloud tenants
within the provider, to support hierarchical cloud tenants.

This commit updates the field label to be more accurate.

@martinpovolny
Copy link

Restarting travis.

@mzazrivec
Copy link
Contributor

The CI failure is related:

Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -17,11 +17,11 @@
          schema={
            Object {
              "fields": Array [
                Object {
                  "component": "select-field",
    -             "label": "Cloud Provider",
    +             "label": "Cloud Provider/Parent Cloud Tenant",
                  "name": "ems_id",
                  "options": Array [
                    Object {
                      "label": "Label 1",
                      "value": 1,

@martinpovolny
Copy link

ping @sseago , pls, fix the spec according to the change you did

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650484

The prior version of this labeled the field "Cloud Provider", but the
actual field content includes both cloud providers and cloud tenants
within the provider, to support hierarchical cloud tenants.

This commit updates the field label to be more accurate.
@h-kataria h-kataria self-assigned this Jan 7, 2019
@h-kataria h-kataria added this to the Sprint 102 Ending Jan 7, 2019 milestone Jan 7, 2019
@h-kataria h-kataria merged commit aa543ed into ManageIQ:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants