Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify sorting in GOD page #5146

Merged
merged 3 commits into from Jan 14, 2019
Merged

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Jan 10, 2019

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1665031

Automate -> Automation -> Generic Object

See that sort in tree and table is different.

For ButtonGroup you may need to change it's set_data[:button_order] to see difference.

For Action add few unassigned button and last one that you add should be with name that should be at the start of the list.

Before:
screen shot 2019-01-10 at 11 26 21 am
screen shot 2019-01-10 at 11 26 13 am
After:
screen shot 2019-01-10 at 11 25 25 am
screen shot 2019-01-10 at 11 25 35 am

@miq-bot add_label bug, generic objects, automate/automation, hammer/yes, gaprindashvili/yes, bugzilla needed

@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2019

@ZitaNemeckova Cannot apply the following label because they are not recognized: automate/automation

@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2019

Checked commits ZitaNemeckova/manageiq-ui-classic@136c2f5~...af2c922 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label automation/automate

@mzazrivec mzazrivec self-assigned this Jan 14, 2019
@mzazrivec mzazrivec added this to the Sprint 103 Ending Jan 21, 2019 milestone Jan 14, 2019
@mzazrivec mzazrivec merged commit d530394 into ManageIQ:master Jan 14, 2019
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label bugzilla needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants