Show breadcrumbs when redirected from another controller #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanSpagetka
force-pushed
the
bz-1655114
branch
3 times, most recently
from
55e0db8
to
236a313
Compare
PanSpagetka
force-pushed
the
bz-1655114
branch
from
236a313
to
8ed520c
Compare
rvsia
reviewed
Jan 10, 2019
| @@ -19,6 +19,11 @@ def self.table_name | |||
| @table_name ||= "ems_cloud" | |||
| end | |||
|
|
|||
| def show | |||
| @breadcrumbs = [{:name => "Cloud Providers", :url => "/ems_cloud/show_list"}] | |||
There was a problem hiding this comment.
Should not be it _('Cloud Providers')? (Same below) 🌐
|
@PanSpagetka The current CI failures seem related to your changes. |
PanSpagetka
force-pushed
the
bz-1655114
branch
from
b1d4497
to
c7dc7ad
Compare
|
Checked commits PanSpagetka/manageiq-ui-classic@8ed520c~...c7dc7ad with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@mzazrivec specs fixed :) |
|
@rvsia Are the current changes OK with you? |
rvsia
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redirect from another (e.g. Alert) controller provider dashboards have no breadcrumbs. In
GenericShowMixinshow_dashboardmethod is dropping breadcrumb, but only for the showed record (one concrete Provider, like Amazon or Openshift instance). Not the upper level of hierarchy (Cloud/Container provider). So there are no breadcrumbs showed.This PR adds the base of breadcrumbs fro providers.
Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1655114
Steps for Testing/QA [Optional]