New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix highlighting the condition in accordion after creating it #5302
Merged
h-kataria
merged 3 commits into
ManageIQ:master
from
hstastna:Accordion_after_creating_condition
Mar 7, 2019
Merged
Fix highlighting the condition in accordion after creating it #5302
h-kataria
merged 3 commits into
ManageIQ:master
from
hstastna:Accordion_after_creating_condition
Mar 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstastna
changed the title
Fix highlighting the condition in accordion after creating it
[WIP] Fix highlighting the condition in accordion after creating it
Mar 4, 2019
@miq-bot add_label bug, hammer/yes |
hstastna
force-pushed
the
Accordion_after_creating_condition
branch
3 times, most recently
from
March 6, 2019 10:53
b88a167
to
cb64d7f
Compare
Move the spec to the right place and refactor it
hstastna
force-pushed
the
Accordion_after_creating_condition
branch
2 times, most recently
from
March 6, 2019 14:45
7a0b606
to
ef7bb86
Compare
hstastna
force-pushed
the
Accordion_after_creating_condition
branch
from
March 6, 2019 15:15
ef7bb86
to
34ee4f1
Compare
hstastna
changed the title
[WIP] Fix highlighting the condition in accordion after creating it
Fix highlighting the condition in accordion after creating it
Mar 6, 2019
@skateman What do you think about the specs? :-) |
Checked commits hstastna/manageiq-ui-classic@e8f4580~...34ee4f1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
I think they're good enough, but this has to be tested in the UI as well. |
verified in UI |
@miq-bot add_label test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1683697
What:
Fix highlighting condition in accordion right after creating it: the newly created condition was not highlighted in accordion as expected, instead of that, All Conditions node was highlighted. Everything else regarding adding new conditions seems to work.
Steps to reproduce:
=> All Conditions node highlighted instead of newly created condition
TODO: (done)
specstest all other types/classes of conditions if it workscheck this also in:policy_tree
,:policy_profile_tree
- there is similar code for setting a new nodeDetails:
@new_condition_node
was set incorrectly (see https://github.com/ManageIQ/manageiq-ui-classic/pull/5302/files#diff-4b771fc8b6101d357855d3d10d79ba8aL69), while adding a new condition, it was set for example to"xx-containerreplicator..."
instead of"xx-containerReplicator..."
Before:
After: