Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable from infra networking controller #5317

Merged
merged 2 commits into from Mar 8, 2019

Conversation

hstastna
Copy link
Contributor

@hstastna hstastna commented Mar 7, 2019

Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1428584
Related PR: #3838

What:
Remove the unused @infra_networking_record variable and use @record instead to update solution for removing Search from Switch summary page (under Compute > Infra > Networking > Switches accordion.)

@hstastna
Copy link
Contributor Author

hstastna commented Mar 7, 2019

@miq-bot add_label bug, gaprindashvili/yes, hammer/yes

Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1428584

Remove the variable to update solution for removing Search
from Switch summary page.
@hstastna hstastna force-pushed the Remove_Search_Switch_summary2 branch from 72c1b1e to 65f11d7 Compare March 7, 2019 13:10
@hstastna hstastna force-pushed the Remove_Search_Switch_summary2 branch from 65f11d7 to b1ee271 Compare March 7, 2019 13:11
@miq-bot
Copy link
Member

miq-bot commented Mar 7, 2019

Checked commits hstastna/manageiq-ui-classic@26742ac~...b1ee271 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Mar 8, 2019
@mzazrivec mzazrivec added this to the Sprint 107 Ending Mar 18, 2019 milestone Mar 8, 2019
@mzazrivec mzazrivec merged commit 3c2bcb8 into ManageIQ:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants