Don't throw exception when template is not found in Provisioning #5345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
skateman
suggested changes
Mar 18, 2019
|
Checked commit PanSpagetka@c00ac93 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
skateman
reviewed
Mar 20, 2019
| end | ||
| @record = | ||
| if @edit[:new][:src_configured_system_ids].present? | ||
| PhysicalServer.where(:id => @edit[:new][:src_configured_system_ids].first).first |
There was a problem hiding this comment.
Maybe take is semantically more accurate instead of first, but I leave the decision to you.
simaishi
pushed a commit
that referenced
this pull request
Mar 29, 2019
Don't throw exception when template is not found in Provisioning (cherry picked from commit e7b0336) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693740
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3928 was added tooltip for Volume tab in provision form. However, this sometimes causes problems when Template is not found and breaks the form. Because Provision form is used for multiple usecases (Provision, Clone, Publish,...?) and it is not clear when it could fail I think safest solution is just wrap it in try-catch block. I am not very satisfied with this, but it fixes the issue and it doesn't add to much complexity.
Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1687946
Related PRs:
#3928
#4511
Steps for Testing/QA [Optional]
Try to Provision, Clone, Publish VM
ping @skateman