Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use supports_volume_resizing? to toggle the Volume size field #5346

Merged
merged 1 commit into from Mar 19, 2019

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Mar 15, 2019

The Openstack and Amazon providers both theoretically support resizing volumes, but currently detection of this feature is done in the UI via a conditional on the class name of the provider. This PR allows the field to be enabled via feature detection.

Depends on ManageIQ/manageiq#18560
See also ManageIQ/manageiq-providers-openstack#448

@miq-bot miq-bot added the wip label Mar 15, 2019
@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2019

Checked commit mansam@2267df0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@mansam mansam changed the title [WIP] Use supports_volume_resizing? to toggle the Volume size field Use supports_volume_resizing? to toggle the Volume size field Mar 15, 2019
@mansam mansam changed the title Use supports_volume_resizing? to toggle the Volume size field [WIP] Use supports_volume_resizing? to toggle the Volume size field Mar 15, 2019
@mansam mansam changed the title [WIP] Use supports_volume_resizing? to toggle the Volume size field Use supports_volume_resizing? to toggle the Volume size field Mar 15, 2019
@miq-bot miq-bot removed the wip label Mar 15, 2019
@mzazrivec mzazrivec self-assigned this Mar 19, 2019
@mzazrivec mzazrivec added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 19, 2019
@mzazrivec mzazrivec merged commit d8acd26 into ManageIQ:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants