Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the proper EAP icon for EAP 6.4 instead of using default icon #537

Merged
merged 1 commit into from Mar 2, 2017
Merged

Use the proper EAP icon for EAP 6.4 instead of using default icon #537

merged 1 commit into from Mar 2, 2017

Conversation

mtho11
Copy link
Contributor

@mtho11 mtho11 commented Mar 2, 2017

We recently added the ability to pull in EAP 6.4 servers (in addition to EAP 7) however, the icon shows as the default Hawkular icon and not a EAP icon. This PR fixes that.

manageiq__middleware_servers

manageiq__middleware_servers

Refer to BZ1426313: https://bugzilla.redhat.com/show_bug.cgi?id=1426313

@mtho11
Copy link
Contributor Author

mtho11 commented Mar 2, 2017

@miq-bot add_label ui, middleware, bug

@miq-bot
Copy link
Member

miq-bot commented Mar 2, 2017

Checked commit https://github.com/mtho11/manageiq-ui-classic/commit/bfa7bb4f7c07deea710940b4799a1fe316781576 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@mtho11
Copy link
Contributor Author

mtho11 commented Mar 2, 2017

@miq-bot assign @bronaghs

@pilhuhn please review

@miq-bot
Copy link
Member

miq-bot commented Mar 2, 2017

@mtho11 'bronaghs' is an invalid assignee, ignoring...

@pilhuhn
Copy link
Contributor

pilhuhn commented Mar 2, 2017

LATM (a = awesome :-)
@miq-bot assign @martinpovolny

@pilhuhn
Copy link
Contributor

pilhuhn commented Mar 2, 2017

@miq-bot label euwe/no, darga/no

@miq-bot
Copy link
Member

miq-bot commented Mar 2, 2017

@pilhuhn unrecognized command 'label', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@pilhuhn
Copy link
Contributor

pilhuhn commented Mar 2, 2017

@miq-bot add_label euwe/no, darga/no

@martinpovolny martinpovolny merged commit 73a1389 into ManageIQ:master Mar 2, 2017
@martinpovolny martinpovolny added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 2, 2017
@mtho11 mtho11 deleted the change_eap64_server_icon branch March 3, 2017 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants