Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing default value for date/time picker in service dialog preview #5400

Merged
merged 1 commit into from Apr 15, 2019

Conversation

romanblanco
Copy link
Member

@romanblanco romanblanco commented Apr 1, 2019

Displays correct date&time if there is a default value set.
If no default time is set, current date will be displayed.

Screencast from 2019-04-02 08-35-25

Links

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1706848

@miq-bot
Copy link
Member

miq-bot commented Apr 2, 2019

Checked commit romanblanco@82f279a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@h-kataria h-kataria self-assigned this Apr 15, 2019
@h-kataria h-kataria added this to the Sprint 109 Ending Apr 15, 2019 milestone Apr 15, 2019
@h-kataria h-kataria merged commit bf21a6e into ManageIQ:master Apr 15, 2019
@romanblanco romanblanco deleted the bz1686077 branch April 16, 2019 09:42
@romanblanco
Copy link
Member Author

simaishi pushed a commit that referenced this pull request May 21, 2019
Showing default value for date/time picker in service dialog preview

(cherry picked from commit bf21a6e)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1712462
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 2d87743f9ffaaed93849f3f3ef9a7719be7f91a6
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Apr 15 12:42:12 2019 -0400

    Merge pull request #5400 from romanblanco/bz1686077
    
    Showing default value for date/time picker in service dialog preview
    
    (cherry picked from commit bf21a6e5981729cffd4f4449427c0532fa11cc12)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1712462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants