Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop always false tertiary conditional from TreeBuilderCatalogItems #5413

Merged
merged 1 commit into from Apr 1, 2019
Merged

Drop always false tertiary conditional from TreeBuilderCatalogItems #5413

merged 1 commit into from Apr 1, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Apr 1, 2019

The :svvcat is definitely a typo of :svccat, but the tree type is sandt so the conditional would be false anyway.

@miq-bot add_reviewer @h-kataria
@miq-bot add_label cleanup, trees, hammer/no

@miq-bot miq-bot requested a review from h-kataria April 1, 2019 19:22
@h-kataria h-kataria self-assigned this Apr 1, 2019
@h-kataria h-kataria added this to the Sprint 108 Ending Apr 1, 2019 milestone Apr 1, 2019
@h-kataria h-kataria merged commit cd685f7 into ManageIQ:master Apr 1, 2019
@skateman skateman deleted the catitems-tree-false branch April 1, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria approved these changes

Assignees

@h-kataria h-kataria

Labels
cleanup hammer/no trees
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skateman @h-kataria @miq-bot