Fix: error loading configuration screen when key/value settings exists on top level #5428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parameter 'hashin' passed to copy_hash(hashin) is not instanse of Hash and error raised [NoMethodError] undefined method 'deep_clone'... Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1695566
|
Checked commit yrudman@de010a9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add-label hammer/yes |
mzazrivec
approved these changes
Apr 5, 2019
|
@miq-bot add-label changelog/yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When settings value added on root level (without category) attempt to execute
copy_hash(hashin)will raise[NoMethodError] undefined method 'deep_clone'...Example:
execute
curl --user admin:smartvm -i -X PATCH -d '{"some_key": false}' http://<host>/api/servers/3/settingswill add:some_key: falsesettings on the top levelBEFORE:
AFTER:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1695566
@miq-bot add-label bug